Mixing persistence concerns specifically with domain logic – and more precisely – with entity logic, would be a SoC problem.

Not necessarily, it could be an accepted violation. Active Record couples database structure with the model, so you could say RoR is a ginormous SoC violation. The trick is to know when you need Domain Model versus Active Record.

Am I wrong in thinking that this is bad practice for a LINQ-To-SQL powered DAL? It seems to be a major violation of the Seperation of Concerns. Mixing persistence concerns with the domain.

I totally agree. Having that “before and after” picture could be a huge learning tool for devs trying to learn MVC. Hopefully someone will take the time to highlight the major areas of change once Oxite has been refactored.

A lot of people are damning Oxite without actually taking the opportunity to explain what is wrong, and how it should be changed.

The mistakes in Oxite are likely to be repeated by other developers (regardless of whether they have seen Oxite or not). This is an excellent opportunity for a public peer review, that can help steer people to best practices.

Having Oxite alpha+peer review+Oxite Refactored would help the community even more, than Oxite having been great from the start.

I would like to point out that the XSS vulnerability you mention was in an earlier drop of the code and a fix was checked in shortly there after… more of an FYI that anything else.

In the Old Way, this would’ve been done behind the scenes and then just released without much opportunity for feedback.

Oxite represents a big (positive) shift forward for Microsoft in how it relates to developers.

I considered doing so, but I thought that it might be inappropriate in public and that I should work with the Oxite team. What are your thoughts? Would it be good and a positive thing, or would it just look like a big indictment or something negative?

I saw Rob Connery’s post and I think he covers the issues well. All the problems I have with Oxite can fit comfortably within his 6 topics-of-concern.

Do you think I should do a breakdown? I feel that his post covers the larger issues and provide a good framework from which to move forward to resolve Oxite’s issues. I’m afraid anything I add to this will only be harmful.

Maybe if I do it positively and constructively as a “Problem: Foo. Solution: Bar” type thing it would be help vs. harm?

Thanks for the feedback, I’m interested to hear your responses!

The key is, if that feedback is taken and used to make it better, then we all benefit.