Comments on: The Aggressive Class vs The Laid Back Class

By: ...

... — Mon, 02 Feb 2009 01:29:03 +0000

Oh, its great!

By: Trevor

Trevor — Wed, 21 Jan 2009 18:44:22 +0000

Nice post, good example, short and to the point.

By: Michael A. Smith

Michael A. Smith — Sun, 18 Jan 2009 00:20:02 +0000

Excellent post Sean. I imagine you can further refactor it using the dynamic capabilities of C# 4.0:


IEnumerable GetPartsInPriceRange()

{

        dynamic price = configuration.GetPrice();

        dynamic parts = partsRepository.GetParts();

        return parts.Where(x => x.IsInPriceRange(price));

}

(assuming of course the IConfiguration, and IPartsRepository interfaces were defined as required).

Did I say it would be “refactoring”? I meant it would be an egregious effort to make a more reusable but less maintainable component.

By: Chris Missal

Chris Missal — Sat, 17 Jan 2009 21:44:38 +0000

Thanks for the heads up Sean! I think all the code typos are corrected now.

By: Sean Stapleton

Sean Stapleton — Sat, 17 Jan 2009 21:29:05 +0000

So here is how i interpret sample 3:

public interface IPart
{
bool IsInPriceRange(int price);
}

public interface IConfiguration
{
int GetPrice () where PART : IPart;
}

public interface IPartsRepository
{
List GetParts () where PART : IPart;
}

public class ComputerBuilder
{
private readonly IConfiguration configuration;
private readonly IPartsRepository partsRepository;

public ComputerBuilder(IConfiguration configuration, IPartsRepository partsRepository)
{
this.configuration = configuration;
this.partsRepository = partsRepository;
}

IEnumerable GetPartsInPriceRange () where PART : IPart
{
var price = configuration.GetPrice ();
var parts = partsRepository.GetParts ();
return parts.FindAll(x => x.IsInPriceRange(price));
}
}

By: Sean Stapleton

Sean Stapleton — Sat, 17 Jan 2009 21:24:36 +0000

Useful discussion, would be more useful if the code samples didn’t throw brain exceptions…

Sample 1, line 34:
return new Configuration(filename);

Sample 3:
You’ve lost a ton of angle brackets in the translation here.

e.g., line 12 is something like:
IEnumerable GetPartsInPriceRange () where PART : IPart

… at least this is what i assume you were trying to convey.

By: chrissie1

chrissie1 — Sat, 17 Jan 2009 18:12:17 +0000

No, no, a good programmer is by default lazy as a concequence he writes better and faster software so he can do less. And he learns new things to prevent himself from doing to much.

The go-get-em programmer will do first and ask questions later. The lazy programmer thins firsts then chooses the path of least resistance. It was a lazy programmer that invented TDD and the SOLID principle because he was tired of solving the same bugs over and over again.

That’s my excuse anyway ;-)..