Comments on: Refactoring legacy code

By: bob

bob — Sun, 18 Apr 2010 07:46:35 +0000

“var c = 2 * Math.Atan2(Math.Sqrt(a), Math.Sqrt(1 – a));” can be simplified to “var c = 2 * Math.Asin(Math.Sqrt(a));”

By: Pawinder Gupta

Pawinder Gupta — Fri, 11 Sep 2009 07:48:41 +0000

Great article with nice examples.

By: Stephan Schmidt

Stephan Schmidt — Wed, 04 Mar 2009 06:48:44 +0000

How much better would it have been to not use double, long, int for return types (in C fashion) but write OO code and return a distance object? (with a getUnit Method? And a asKilometers() method). Easier to read and understand, less bugs.

http://www.codemonkeyism.com/archives/2008/05/02/never-never-never-use-string-in-java-or-at-least-less-often/

Peace
Stephan

By: Gabriel N. Schenker

Gabriel N. Schenker — Tue, 03 Mar 2009 10:56:24 +0000

@Jacob: yes you are right! If a ValueObject is immutable I do not have to clone it but can just use it as it is… Sometimes I hurry too much.

By: Jacob Stanley

Jacob Stanley — Tue, 03 Mar 2009 02:21:58 +0000

If GeoCoordinate is immutable then you might as well trash your Clone function or change it to:

public GeoCoordinate Clone()
{
return this;
}

By: David

David — Sun, 01 Mar 2009 23:19:24 +0000

I particularly appreciated your explanation of how to avoid SRP violations.

By: Mike

Mike — Sun, 01 Mar 2009 00:00:06 +0000

Before scrolling further I was wondering why the calculation was being done in a service instead of in GeoCoordinate, guess that’s a good sign

By: Ryan Svihla

Ryan Svihla — Sat, 28 Feb 2009 20:36:39 +0000

I do the wrapper trick on rough api’s all the time myself. However,was it intentional to use an interface name that is already part of the .net framework?

http://msdn.microsoft.com/en-us/library/system.data.idatareader.aspx

By: redgreenrefactor

redgreenrefactor — Sat, 28 Feb 2009 18:40:12 +0000

A great tool for creating interfaces and wrappers when classes do not implement an interface or when you want to make use of a decorator. http://code.google.com/p/doubler/

By: Kyle Szklenski

Kyle Szklenski — Sat, 28 Feb 2009 12:27:54 +0000

Pretty good! Although, if you were really that anal retentive, you would know the rules for apostrophes and possessives, I should think!

Interestingly, the last place I work had almost the exact same code as presented here (they were also GIS-related). . .I certainly hope you’re not working for them! Their codebase would be nigh impossible to refactor properly without losing your mind. I know because I tried. . .and went insane.