Comments on: Guidelines aren’t rules http://lostechies.com/jimmybogard/2008/04/15/guidelines-aren-t-rules/ Strong opinions, weakly held Thu, 23 May 2013 23:40:00 +0000 hourly 1 http://wordpress.org/?v=3.4.2 By: Jimmy Bogard http://lostechies.com/jimmybogard/2008/04/15/guidelines-aren-t-rules/#comment-324 Jimmy Bogard Thu, 17 Apr 2008 21:24:27 +0000 /blogs/jimmy_bogard/archive/2008/04/15/guidelines-aren-t-rules.aspx#comment-324 No offense Mark, but that's about the ugliest way of describing "BeforeAction" I've seen. Those conventions are for events, which this is clearly not an event. These are method calls on an attribute. It's like someone had a contest, "who can think of the most obfuscated name to call a Before and After method". It only removes ambiguity for those that are already familiar with event naming conventions. Event naming conventions remove possibilities for other options, like "Around", which _all_ other frameworks listed allow. public void OnCommentWritingFinished() { Sigh(); } No offense Mark, but that’s about the ugliest way of describing “BeforeAction” I’ve seen.

Those conventions are for events, which this is clearly not an event. These are method calls on an attribute. It’s like someone had a contest, “who can think of the most obfuscated name to call a Before and After method”. It only removes ambiguity for those that are already familiar with event naming conventions.

Event naming conventions remove possibilities for other options, like “Around”, which _all_ other frameworks listed allow.

public void OnCommentWritingFinished()
{
Sigh();
}

]]> By: Mark Brackett http://lostechies.com/jimmybogard/2008/04/15/guidelines-aren-t-rules/#comment-323 Mark Brackett Thu, 17 Apr 2008 19:53:25 +0000 /blogs/jimmy_bogard/archive/2008/04/15/guidelines-aren-t-rules.aspx#comment-323 I dunno - seeing as how we (.NET devs, that is) are all used to the <Event>ing and <Event>ed naming convention, it's not too much of a leap to apply that to On<action>ing, and On<action>ed. The consistency of that naming convention wins out to me, vs. the Before/After pair. The only thing that might give me pause is if there was a chance that you could actually be in the process of <action>ing, and then there'd be some confusion between before and during. But, with an ActionAttribute (like an event), there really is no chance for "during". But, since I was confused for a bit about the "Action" (thinking it was my "Action" that was being referred to, instead of the ControllerAction), I'd vote for OnControllerActionExecuting. That removes all ambiguity for me. I dunno – seeing as how we (.NET devs, that is) are all used to the ing and ed naming convention, it’s not too much of a leap to apply that to Oning, and Oned. The consistency of that naming convention wins out to me, vs. the Before/After pair.

The only thing that might give me pause is if there was a chance that you could actually be in the process of ing, and then there’d be some confusion between before and during. But, with an ActionAttribute (like an event), there really is no chance for “during”.

But, since I was confused for a bit about the “Action” (thinking it was my “Action” that was being referred to, instead of the ControllerAction), I’d vote for OnControllerActionExecuting. That removes all ambiguity for me.

]]> By: Sergio Pereira http://lostechies.com/jimmybogard/2008/04/15/guidelines-aren-t-rules/#comment-322 Sergio Pereira Tue, 15 Apr 2008 16:59:12 +0000 /blogs/jimmy_bogard/archive/2008/04/15/guidelines-aren-t-rules.aspx#comment-322 Very true. This is a plague spread by careless modeling. Thank God for the current crop of OSS .Net projects, which draw inspiration from the right places. Very true. This is a plague spread by careless modeling. Thank God for the current crop of OSS .Net projects, which draw inspiration from the right places.

]]>