Comments on: Attributes are lousy decorators

By: Anonymous

Anonymous — Fri, 25 Nov 2011 18:32:00 +0000

Yeah, I agree, but I don’t like that the attribute instance itself supplies the behavior. Attributes just really aren’t meant for that.

By: Luckykashyap4u

Luckykashyap4u — Fri, 25 Nov 2011 11:43:00 +0000

Since attributes can be placed on both method and class declarations,
this would seem like an ideal candidate to specify before/after behavior
on a controller action.

By: Writing Jobs

Writing Jobs — Wed, 24 Feb 2010 08:16:06 +0000

The other place I’ve noticed this (attributes providing more than data) is the ValidationAttribute in Dynamic Data. I’m not a fan of this either since it’s difficult to reuse any code stored in these attribute, especially complex validation (which certainly shouldn’t be in one).

By: bogardj

bogardj — Tue, 09 Dec 2008 13:56:57 +0000

@James

Because then we’re not using IoC. We want our dependencies explicit, and a lazy-loaded property makes it opaque or appear optional.

By: James Brechtel

James Brechtel — Tue, 09 Dec 2008 13:03:39 +0000

Why not lazy load the ICustomerRepository on the BadBadFilterAttribute via a property?

By: Mogens Heller Grabe

Mogens Heller Grabe — Tue, 09 Dec 2008 09:11:43 +0000

This is a great example on why it’s hard to create a framework. At first something seems like a cool and easy solution, but when people start using it, stuff like this just happens.

Makes you wonder why Microsoft bother building MVC, the Entity Framework etc. when there are truly mature solutions like MonoRail and NHibernate around.

By: Nigel Sampson

Nigel Sampson — Tue, 09 Dec 2008 06:11:36 +0000