Comments on: Refactoring challenge #2 – functionally illiterate http://lostechies.com/jimmybogard/2009/07/27/refactoring-challenge-2-functionally-illiterate/ Strong opinions, weakly held Wed, 22 May 2013 13:39:00 +0000 hourly 1 http://wordpress.org/?v=3.4.2 By: bogardj http://lostechies.com/jimmybogard/2009/07/27/refactoring-challenge-2-functionally-illiterate/#comment-1754 bogardj Mon, 27 Jul 2009 12:17:39 +0000 /blogs/jimmy_bogard/archive/2009/07/26/refactoring-challenge-2-functionally-illiterate.aspx#comment-1754 @tom I agree, I don't like the idea of the method returning a boolean. Ideally, the collecting parameter (LinkedList) would be the indication that the matching was successful or not. The trick is to preserve the order, and be able to follow multiple paths. @tom

I agree, I don’t like the idea of the method returning a boolean. Ideally, the collecting parameter (LinkedList) would be the indication that the matching was successful or not. The trick is to preserve the order, and be able to follow multiple paths.

]]> By: Tom de Koning http://lostechies.com/jimmybogard/2009/07/27/refactoring-challenge-2-functionally-illiterate/#comment-1753 Tom de Koning Mon, 27 Jul 2009 08:10:12 +0000 /blogs/jimmy_bogard/archive/2009/07/26/refactoring-challenge-2-functionally-illiterate.aspx#comment-1753 What about CQS in MapDestinationPropertyToSource? The if makes no sense in the conditional flow of CreateTypeMap. I would separate that first, ie introduce another layer before worrying too much about the functional issus.. What about CQS in MapDestinationPropertyToSource? The if makes no sense in the conditional flow of CreateTypeMap. I would separate that first, ie introduce another layer before worrying too much about the functional issus..

]]>