Comments on: Testing with queries and repositories (a simple example) http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/ Strong opinions, weakly held Thu, 23 May 2013 23:40:00 +0000 hourly 1 http://wordpress.org/?v=3.4.2 By: Asier Barrenetxea http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5281 Asier Barrenetxea Thu, 08 Nov 2012 07:48:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5281 In my opinion, that test to the controller looks dull because the code itself is dull. So it feels like we are overdoing things. I mean, you are mimicking the controller action in the repository, basically the method in the repository and the controller have the same signature - almost same arguments, same output. Is this right? what's the reuse of that QueryPostStats method? None. It is very specific to this and just this action in the controller. In my opinion, that test to the controller looks dull because the code itself is dull. So it feels like we are overdoing things.
I mean, you are mimicking the controller action in the repository, basically the method in the repository and the controller have the same signature – almost same arguments, same output. Is this right? what’s the reuse of that QueryPostStats method? None. It is very specific to this and just this action in the controller.

]]> By: Paul Connolly http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5272 Paul Connolly Wed, 07 Nov 2012 21:17:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5272 You are pretty much testing the flow of the calls in the controller. Especially a lot of "AssertWasCalled" stuff which basically just verifies the lines I've written, nothing to do with verifiying logic. You are pretty much testing the flow of the calls in the controller. Especially a lot of “AssertWasCalled” stuff which basically just verifies the lines I’ve written, nothing to do with verifiying logic.

]]> By: jbogard http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5269 jbogard Wed, 07 Nov 2012 14:14:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5269 Not my code, I'm just refactoring someone else's. I have no idea! Not my code, I’m just refactoring someone else’s. I have no idea!

]]> By: Terence Lewis http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5268 Terence Lewis Wed, 07 Nov 2012 13:58:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5268 Transposing the out and return parameters between your repository implementation and Raven's .Statistics() method distracted me a little. I realize it's tangential to your point, but was there a reason for this that I'm not aware of? Transposing the out and return parameters between your repository implementation and Raven’s .Statistics() method distracted me a little. I realize it’s tangential to your point, but was there a reason for this that I’m not aware of?

]]> By: jbogard http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5267 jbogard Wed, 07 Nov 2012 13:24:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5267 I think the value of unit tests to help in this situation is overstated. When I've seen junior teams take over for more senior ones, typically what happens is that the tests simply aren't run, commented out, or marked explicit. What you're describing is not so much a failure in code, but a failure in management and team building. I think the value of unit tests to help in this situation is overstated. When I’ve seen junior teams take over for more senior ones, typically what happens is that the tests simply aren’t run, commented out, or marked explicit. What you’re describing is not so much a failure in code, but a failure in management and team building.

]]> By: What am I Testing? « danielksmith http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5265 What am I Testing? « danielksmith Wed, 07 Nov 2012 12:51:47 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5265 [...] morning I read this post by Jimmy Bogard on Los Techies. To me he seems to be saying why write tests for the three lines of code in a controller action, [...] [...] morning I read this post by Jimmy Bogard on Los Techies. To me he seems to be saying why write tests for the three lines of code in a controller action, [...]

]]> By: The Morning Brew - Chris Alcock » The Morning Brew #1227 http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5264 The Morning Brew - Chris Alcock » The Morning Brew #1227 Wed, 07 Nov 2012 10:25:35 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5264 [...] Testing with queries and repositories (a simple example) - Jimmy Bogard discusses the value in testing controllers and queries when using a repository pattern to handle the querying part, suggesting that the controller may not need a test, and that the repository could be integration tested. [...] [...] Testing with queries and repositories (a simple example) – Jimmy Bogard discusses the value in testing controllers and queries when using a repository pattern to handle the querying part, suggesting that the controller may not need a test, and that the repository could be integration tested. [...]

]]> By: Tudor http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5263 Tudor Wed, 07 Nov 2012 09:49:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5263 In my opinion, the value in unit testing the controller itself, even it's just 4 lines of code, shows when, 4 years later, when the original developer is long gone from the company, some junior developer has to make some changes in that part of the application, and assumes it's safe to do some "small" changes, that are not caught at compile time.. This, and the fact that people usually are to lazy to run the integration tests because they take too much to run, or they don't write any integration tests.. In my opinion, the value in unit testing the controller itself, even it’s just 4 lines of code, shows when, 4 years later, when the original developer is long gone from the company, some junior developer has to make some changes in that part of the application, and assumes it’s safe to do some “small” changes, that are not caught at compile time..

This, and the fact that people usually are to lazy to run the integration tests because they take too much to run, or they don’t write any integration tests..

]]> By: KevinLaBranche http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5260 KevinLaBranche Tue, 06 Nov 2012 17:41:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5260 And you've answered my question to your earlier post on the matter. Perfect. :-) And you’ve answered my question to your earlier post on the matter. Perfect. :-)

]]> By: jbogard http://lostechies.com/jimmybogard/2012/11/06/testing-with-queries-and-repositories-a-simple-example/#comment-5259 jbogard Tue, 06 Nov 2012 17:27:00 +0000 http://lostechies.com/jimmybogard/?p=687#comment-5259 Good question! That's in the next post, for the "complex" example. Good question! That’s in the next post, for the “complex” example.

]]>