Comments on: Real World Refactoring

By: Jason Meridth

Jason Meridth — Wed, 01 Jul 2009 04:34:36 +0000

Excellent write-up Josh. Showed this to a few friends having issues understanding OCP, DIP and ISP. This was perfect real world example.

By: zbigg

zbigg — Mon, 29 Jun 2009 14:42:19 +0000

Agree with pulling up registration outside. But this introspection thing is one step too far:

1. Explicit declaration of parser list is great place for self documenting all comment parsing rules:

2. For first time reader it’s very easy to find these rules at first look without browsing whole source tree.

3. They create readable and trackable explicit dependency.

As long as program is quite monolithic one shouldn’t put plugin interfaces everywhere. Plugin/extension points should be choosen carefully and not by making everything pluggable.

By: James Gregory

James Gregory — Mon, 29 Jun 2009 11:12:35 +0000

Hey Josh,

Excellent refactoring, and a great writeup too. The pulling up of the responsibility to the bootstrapper makes the parser much more flexible too, as you can substitute the node parsers depending on configuration (or environment).

We need more examples like this. I’ll gladly write some more highly coupled code if you’ll write up how to fix it ;)

Thanks again for putting the work into Docu as well, it’s much appreciated.