Comments on: PTOM: The Interface Segregation Principle

By: Carl J

Carl J — Mon, 14 Dec 2009 14:43:40 +0000

Ignore that last comment. Its too early, and got slightly mixed up with the Liskov Substitution Principle.

By: Carl J

Carl J — Mon, 14 Dec 2009 14:15:30 +0000

I thought that the main point of the “I” in SOLID, was that all classes that implement an Interface, have to have the exact same methods and signatures, no more, and no less.

By: Eric Swann

Eric Swann — Mon, 17 Mar 2008 20:06:31 +0000

I was messing around with the membership provider this week. I was writing a custom provider to wrap a Castle ActiveRecord implementation. It’s definitely a little over the top.

By: Ray Houston

Ray Houston — Sun, 16 Mar 2008 01:27:19 +0000

@Colin – ah, after re-reading I noticed I did overload the term “implement” quite a bit. Hopefully it won’t trip anybody up too much.

By: Colin Jack

Colin Jack — Sat, 15 Mar 2008 16:16:07 +0000

Although I’m a fan of Robert Martin I think I might have to use Yahoo Pipes to filter out all of these articles before my RSS gets swamped with them

MembershipProvider is one of the WORST API I have ever seen and as you say ISP wise its a complete joke. It and the closely related API’s are and violate many of RM’s principles and in fact many of the framework design guidelines.

I mean look at MembershipProvider.CreateUser (http://msdn2.microsoft.com/en-us/library/system.web.security.membershipprovider.createuser.aspx). First 5 arguments are strings, wonderful. Then a bool, an object and an output parameter that says whether it succeeded. Need I go on (I did go on in a MS Connect item for it which MS closed :https://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=159377)

Small comment but I think when most people use the term implement in regards to an interface they think you mean the inheritor. You make it clear what you mean but I just thought it might be confusing.

By: Jarod

Jarod — Sat, 15 Mar 2008 07:12:36 +0000

Nice! Another great contribution to the S.O.L.I.D posts you guys are doing.

Though, somewhere down inside I really want to throw a RattleSnakeGroomException(“DOOOD!!!!! WTF are you doing grooming a snake?”); but I guess that kind of fun would violate ISP & LSP, so ill refrain.