Comments on: Refactoring Day 2 : Move Method

By: Cameron Scott

Cameron Scott — Tue, 25 Oct 2011 10:30:00 +0000

Since it can be difficult to find human opponents for a face-to-face game and I don’t like playing against the computer, I will have to try out the internet chess site. Thanks for the info.

http://healthconditions.edublogs.org/

By: nfma

nfma — Sat, 24 Oct 2009 14:08:19 +0000

@Arnis, I agree with Frank. If I looked at the code from the solution I tended to refactor it to match the original code.

By: Arnis L.

Arnis L. — Tue, 08 Sep 2009 12:48:19 +0000

@Frank it’s not. Bad code gets refactored – this one suits perfectly.

By: Frank

Frank — Sun, 16 Aug 2009 19:07:24 +0000

In my opinion this is a bad refactoring example, since the calculate interest method is best suited to the account class, since that class owns all the data necessary for making the decision.

By: schambers

schambers — Sun, 02 Aug 2009 16:00:21 +0000

Obviously these are brief contrived examples so there is no usage surrounding them. This is for brevity.

You are correct about the circular dependencies though. I didn’t catch that while making the example. Let’s just pretend that there is no circular dependency there. k?

By: Neil Mosafi

Neil Mosafi — Sun, 02 Aug 2009 15:25:22 +0000

I’m not sure about the purpose of the classes here, and whatsmore you seem to have a circular dependency in your constructors – you can’t construct a BankAccount without an AccountInterest and you can’t construct an AccountInterest without a BankAccount!