Comments on: Refactoring Day 5 : Pull Up Field http://lostechies.com/seanchambers/2009/08/05/refactoring-day-5-pull-up-field/ Just another LosTechies site Thu, 13 Sep 2012 07:11:00 +0000 hourly 1 http://wordpress.org/?v=3.4.2 By: nfma http://lostechies.com/seanchambers/2009/08/05/refactoring-day-5-pull-up-field/#comment-382 nfma Sat, 24 Oct 2009 14:23:28 +0000 /blogs/sean_chambers/archive/2009/08/05/refactoring-day-5-pull-up-field.aspx#comment-382 @Thomas Eyde Some refactorings are just steps on other bigger refactorings. Pull up method might make sense in the context... @Thomas Eyde

Some refactorings are just steps on other bigger refactorings. Pull up method might make sense in the context…

]]> By: Ed http://lostechies.com/seanchambers/2009/08/05/refactoring-day-5-pull-up-field/#comment-381 Ed Wed, 19 Aug 2009 16:07:15 +0000 /blogs/sean_chambers/archive/2009/08/05/refactoring-day-5-pull-up-field.aspx#comment-381 I would say pulling anything up into a base class should be done with caution It's likely to lead to a fragile base class. Favour composition over inheritence, using inheritence as a mechanism for reuse iis picking the option with the tightest coupling from the word go I would say pulling anything up into a base class should be done with caution

It’s likely to lead to a fragile base class. Favour composition over inheritence, using inheritence as a mechanism for reuse iis picking the option with the tightest coupling from the word go

]]> By: Thomas Eyde http://lostechies.com/seanchambers/2009/08/05/refactoring-day-5-pull-up-field/#comment-380 Thomas Eyde Thu, 06 Aug 2009 07:07:24 +0000 /blogs/sean_chambers/archive/2009/08/05/refactoring-day-5-pull-up-field.aspx#comment-380 I don't like that refactoring, kind of. I think it's incomplete. It's all about preferences, though, but I think protected fields are a code smell: - if you need access to a base class field, you probably have some kind of feature envy. Try Templated Method or something similar. - There is nothing in the subclass telling you that this field exists, you just have to know it. It hurts readability. I don’t like that refactoring, kind of. I think it’s incomplete. It’s all about preferences, though, but I think protected fields are a code smell:

- if you need access to a base class field, you probably have some kind of feature envy. Try Templated Method or something similar.

- There is nothing in the subclass telling you that this field exists, you just have to know it. It hurts readability.

]]>